fix: handle SSE in copyObject() properly and have one source code. #777
+165
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
fix-handle-sse-in-copyObject
branch
from
7c2a2e4
to
8be1064
Compare
|
Build issue |
balamurugana
force-pushed
the
fix-handle-sse-in-copyObject
branch
from
8be1064
to
4bbd323
Compare
aead
previously approved these changes
Jul 16, 2019
|
@balamurugana I see changes to getObject API. Can you please change the commit title and the message to reflect the changes ? It can be done in the PR title and description. I can use it while merging it. |
|
I believe Readme.md also should be updated |
|
Please resolve the conflicts @balamurugana |
Added new version of copyObject(). Note: this method makes source and
destination argument swapping correctly to denote on which bucket and
object the request is sent.
```
public void copyObject(String bucketName, String objectName, Map<String,String> headerMap, ServerSideEncryption sse,
String srcBucketName, String srcObjectName, ServerSideEncryption srcSse,
CopyConditions copyConditions)
```
balamurugana
force-pushed
the
fix-handle-sse-in-copyObject
branch
from
4bbd323
to
d1273e1
Compare
|
ping @aead @sinhaashish |
aead
approved these changes
Jul 30, 2019
|
ping @sinhaashish |
1 similar comment
|
ping @sinhaashish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new version of copyObject(). Note: this method makes source and
destination argument swapping correctly to denote on which bucket and
object the request is sent.